Add RPC endpoints to support Trustwallet staking #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathornteng
suggested changes
Sep 12, 2019
| getValidatorResponse := make([]blockatlas.Validator, 0) | ||
| chainID := ctx.Block().ChainID | ||
|
|
||
| for _, validator := range validators { |
There was a problem hiding this comment.
This loop has time complexity equal to n^2. We can do it better by using hash map.
First we loop to save validator address in hash map like
validatorList := map[string]loom.Address
for _, validator := range validators {
validatorList[string(validator.Pubkey)] = loom.Address{ChainID: chainID, Local: loom.LocalAddressFromPublicKey(validator.PubKey)}
}
and then we can just iterate candidates that are in the validators list
atchapcyp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support staking with
trustwallet, We need to provide RPC endpoints to fetch the following data:ref : https://developer.trustwallet.com/staking#step-3-define-rpc-endpoints-for-blockatlas
Issue ref : #1461